-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ipq40xx-generic: add linksys-mr8300 #2769
base: main
Are you sure you want to change the base?
Conversation
The 3MB issue will require every user of this device to increase the partition in u-boot once in the device lifetime for updates beyond OpenWrt 22.03, right? If so, that should be noted a instruction in the PR. Not supporting all three radios qualifies for broken, not supported. I'd favor getting three/n-interface support in gluon done before merging more of these devices, in order not to have to revisit these devices later on, as our time is currently fairly limited. But others might differ. I'll do a full review once we settled on a scope for this device. And leave the following as a starting bit. |
I addressed your notes. That reminds me: I flagged the other two devices as broken in this PR, since they probably are.
Sounds reasonable. I'll wait patiently for you and other maintainers to choose what to do next. |
I have a problem with the definition of "broken". Yes, the third radio (phy2 aka 5GHz IPQ40xx internal radio, aka channel 100+), but we are still using the QCA9888 for indoor installation with channel 36. We could even use that for 160 MHz (with half the NSS) - something which isn't supported with the internal 5GHz phy.
Why can't this be right? It is how it is implemented in HW. You can also verify this in the DTS.
Not sure what your device has to do with the A62/PA2200? It depends on the way the filters are added in front of the radio and what is inside the BDFs - not the actual PHY itself.
Same here. |
Thanks for your quick reply and the explanations :)
You are right. I'm a novice and no hw expert by any means. My first impression while adding my router was that the wifi chip is only capable of certain frequencies. By now I know thanks to your reply that this is not the case. In other words: they had to split the frequency range in two (using filters) to allow wiring both chips to the same antennas. And depending on the board data files (calibration) the chip can act very differently. (If understood you correctly that is)
Maybe because OpenWRT connects to pcie0 first. I read somewhere that radios are ordered in load order after boot up. EDIT: |
sorry, for the spam, I just deleted my last post. I got confused by wikidevi listing my device as 256mb ram while it has 512mb. |
This might also depends on openwrt/openwrt#11693 |
This could be set back to "waiting-on-review" again to avoid confusion |
Your PR is still in draft state. I can mark it as 'waiting-for-review', but that won't be true until you click the button "ready-for-review". It was only labeled as such, as we had worked through a bunch of PRs a few days ago and I wanted others to have a look at yours as well. |
I thought this status would mean you were waiting for input from me and since NeoRaider already resolved his question I wasn't sure what we were waiting for, that's all ^^ I kept this as a draft since I didn't expect this device to be added before tri-band radio support. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe @ecsv can review this; I'd be fine with it, if its actions run through.
Thx, I addressed your requests Edit: |
rebase is necessary |
Done, I also updated the commit date. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codewise this looks fine.
Testing the checklist (after your latest changes) on hardware is mandatory though.
Let me know when you found the time to test it and we can merge this.
@Djfe do you still plan to test this device (after a rebase to the current master branch!) ? |
I redid all tests and updated the installation instructions in the PR description above.
|
Before reading this, take a look at the MACs in the post below :) MAC e8:9f:80:ad:36:c1 (label MAC) is missing entirely in Gluon. (it's either c2, c3 or c4) Issues are caused by the following lines (see openwrt/openwrt@550253b):
Since DSA support there is only eth0. eth1 doesn't exist anymore. In OpenWrt 23.05 the ethernet MACs look correct, while in Gluon they don't. Maybe OpenWrt has additional code to fill in the other LANs/WAN interfaces? For WiFi PHYs I'm wondering, why the LA bit is set by default in OpenWrt 23.05 (ea instead of e8): OpenWrt 22.03 had the most correct MACs. Here only the third wifi radio (wlan0) used the LA bit, but that might be correct in this case. See for yourself: MAC addresses in 23.05 rc3:
MAC addresses in Gluon master:
And for comparison how MACs looked in OpenWrt 22.03:
|
Where I am (Gluon master):
What I want to achieve (Gluon with MACs like OpenWrt 22.03):
|
@Djfe Please attach the |
|
Gluon currently deletes all It might be enough to limit that to devices with a |
Please update the labels. |
Installation instructions:
Access http://192.168.1.1/fwupdate.html (user and password are admin)
Upload and install the factory image of
OpenWrt 22.03.05
.After reboot connect to 192.168.1.1 via ssh and run
fw_setenv kernsize 500000
.This allows U-Boot to boot Kernels upwards of 3MB successfully.
Check
fw_printenv kernsize
to verify the change. The number needs to start with 5 instead of 3.Install the Gluon factory image of your community:
sysupgrade -n -F <gluon-factory.bin>
Yes, sysupgrade is correct here: Pull Request. This device's sysupgrade supports flashing OpenWrt and Linksys factory images.
Full install instructions
Notes on this device:
They are raising compat version to warn users to modify the bootloader environment variable, so maybe let's only add this device in Gluon 2023 at the earliest to avoid a future failure of autoupdate? On the other hand there are communities with older gluon's that might want to have access to this device now while IPQ4019 is still considered good. (OT: IPQ807x was just added and new device support is flooding into OpenWrt)
The router has three WiFi radios. 5GHz channels are split like here: #1661 / #1666
My solution for now: remove kernelpackets for QCA9888-support until triple radio support is implemented.
We could flag the device as broken until then.(done)Freifunk doesn't require dfs channels anyways.
If there is a way to disable outdoor support (aka remove the config entry), then pls tell me where :)
The same thing could be done to add the Fritz!Repeater 3000, so it could atleast be deployed by Freifunk Communities.
Other devices that use the same packages-string: openmesh-a62 and plasma-cloud-pa2200. Does this also fix their 5GHz support? Looking at their dts files, they are triple radio devices as well, but I don't want to break anything accidentally.
How do I remove "dallas" from the expected image name? It might say dallas in the code but that name is not found in OpenWrt's firmware selector and it's also not in the image file (I looked at strings at start and end of the image file).I found this but there is no exceptions for singular devices in there only for broadcom devices as a whole.
Not sure whether this is important:
When I enter config mode all LEDs are supposed to flash once. All of them are except the power led which stays lit throughout the whole reboot. The power led is on top of the router, every other led is on the back.
Also: there is no WiFi led.
sysupgrade [-n]
,firstboot
)(
lua -e 'print(require("platform_info").get_image_name())'
)linksys-mr8300-dallas
- How do I fix this? Can I removedallas
? (See above)(https://gluon.readthedocs.io/en/latest/dev/hardware.html#hardware-support-in-packages)
When re-adding a device that was supported by an earlier version of Gluon, afactory reset must be performed before checking the primary MAC address, as
the setting from the old version is not reset otherwise.
On devices supplied via PoE, there is usually no explicit WAN/LAN labeling on the hardware.The PoE input should be the WAN port in this case.
(https://gluon.readthedocs.io/en/latest/features/configmode.html)
Radio LEDsThere are noneShould map to their respective radioShould show activityOutdoor devices only:Added board name tois_outdoor_device
function inpackage/gluon-core/luasrc/usr/lib/lua/gluon/platform.lua
docs/user/supported_devices.rst